Only record ecosystem versions when flag set #7516
Conversation
|
Smoke test failures are expected, because it doesn't pass the flag. Since this is a flag we'd want to run for all smoke tests, I think we need to update the cli to always pass the flag, rather than updating the individual the smoke tests. |
| # TODO: The flag is named `record_ecosystem_versions` because `package_manager_version` is getting renamed to | ||
| # to that shortly... but splitting into separate PR's for lower risk/easiery testability. Once the follow-on PR | ||
| # with the rename lands, the name confusion will disappear. | ||
| if Experiments.enabled?(:record_ecosystem_versions) |
There was a problem hiding this comment.
Nothing to do with this change, but I wonder if we should eventually split Experiments into Features for long-lived switches and Experiments for short-term ones 🤔
There was a problem hiding this comment.
Totally agree. I think the internal repo that controls setting these flags will be the best place to discuss a potential refactoring (the result of which would then flow out here into core).
There's no point in recording the versions on GHES / non-cloud instances because we can't access that data for telemetry purposes. So put it behind a feature flag. This will also make it so later on when we do the rename of `record_package_manager_version` to `record_ecosystem_versions`, there is less to worry about for backwards incompatible changes on GHES.
jeffwidman
force-pushed
the
require-feature-flag-to-record-versions
branch
from
00b6bdf
to
017b9a2
Compare
|
As mentioned elsewhere, going to merge despite the failing smoke tests as there's a chain of connected PR's around this ecosystem metrics refactor, split apart for easier review, and then will update the smoke tests at the end once they land. |
There's no point in recording the versions on GHES / non-cloud instances because we can't access that data for telemetry purposes. So put it behind a feature flag. This will also make it so later on when we do the rename of `record_package_manager_version` to `record_ecosystem_versions`, there is less to worry about for backwards incompatible changes on GHES.
There's no point in recording the versions on GHES / non-cloud instances because we can't access that data for telemetry purposes. So put it behind a feature flag.
This will also make it so later on when we do the rename of
record_package_manager_versiontorecord_ecosystem_versions, there is less to worry about for backwards incompatible changes on GHES.Before merging this, first need to merge the internal change that sets this feature flag, so that we don't lose visibility on cloud after we merge it.
Related:
ecosystemparam #7492record_ecosystem_versionsendpoint. #7517