Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Layout/DotPosition to leading #7789

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Set Layout/DotPosition to leading #7789

merged 6 commits into from
Sep 8, 2023

Conversation

JamieMagee
Copy link
Contributor

Sets Layout/DotPosition to leading and autofixes.

This will be followed by a PR to introduct .git-blame-ignore-revs to avoid this commit showing up in git blame

See #7782 for more information.

@JamieMagee JamieMagee requested a review from a team as a code owner August 10, 2023 22:14
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages labels Aug 10, 2023
@JamieMagee JamieMagee mentioned this pull request Aug 10, 2023
Open
8 tasks
@JamieMagee
Copy link
Contributor Author

After seeing the number of labels that just got added to this PR 😵‍💫

jurre
jurre approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it, potato/potato on this change in general so if it helps w/ Sorbet adoption 👍

@deivid-rodriguez deivid-rodriguez mentioned this pull request Aug 11, 2023
Merged
@Nishnha Nishnha mentioned this pull request Sep 8, 2023
Merged
@Nishnha Nishnha merged commit 138f7f7 into dependabot:main Sep 8, 2023
79 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/leading-dot-position branch September 8, 2023 21:12
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@Nishnha
Merge pull request dependabot#7789 from JamieMagee/jamiemagee/leading…
652f723 
…-dot-position

Set `Layout/DotPosition` to `leading`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman left review comments

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

@jurre jurre jurre approved these changes

@abdulapopoola abdulapopoola abdulapopoola approved these changes

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JamieMagee @jeffwidman @abdulapopoola @jurre @deivid-rodriguez @Nishnha