Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate response body before mutating it #7926

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Aug 30, 2023

Addresses the following error that is happening in main npm tests :

Failure/Error:
@project_npm_response.body.force_encoding("UTF-8").encode.
include?(project_description)

FrozenError:
can't modify frozen String: ""

Example failure : https://github.com/dependabot/dependabot-core/actions/runs/6019388208/job/16329143018?pr=7811

@yeikel yeikel requested a review from a team as a code owner August 30, 2023 01:19
@yeikel yeikel changed the title fix: duplicate response body before altering it fix: duplicate response body before mutating it Aug 30, 2023
Addresses the following error that is happening in `main` npm tests :

>
> Failure/Error:
> @project_npm_response.body.force_encoding("UTF-8").encode.
> include?(project_description)
>
>  FrozenError:
>    can't modify frozen String: ""

Example failure : https://github.com/dependabot/dependabot-core/actions/runs/6019388208/job/16329143018?pr=7811
Copy link
Member

@landongrindheim landongrindheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jeffwidman
Copy link
Member

Thanks for breaking this out separately!

@jeffwidman jeffwidman merged commit 18552b6 into dependabot:main Aug 30, 2023
96 checks passed
@yeikel yeikel deleted the duplicate/before-mutating branch August 30, 2023 18:05
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Addresses the following error that is happening in `main` npm tests :

>
> Failure/Error:
> @project_npm_response.body.force_encoding("UTF-8").encode.
> include?(project_description)
>
>  FrozenError:
>    can't modify frozen String: ""

Example failure : https://github.com/dependabot/dependabot-core/actions/runs/6019388208/job/16329143018?pr=7811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants