Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move copying the other pythons to the end of the Dockerfile #7941

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jeffwidman
Copy link
Member

This is a multi-stage build, which means that building/tarring these files happens in concurrent builds.

Previously, if one of those builds took longer for some unexpected reason--perhaps a slow HTTP call, then it'd block the pipeline.

By moving them to the bottom, it allows the main image to proceed with apt-get update && apt-get install ... which takes a little bit of time and gives any slow concurrent builds plenty of time to finish.

@jeffwidman jeffwidman requested a review from a team as a code owner August 31, 2023 16:24
This is a multi-stage build, which means that building/tarring these files happens in concurrent builds.

Previously, if one of those builds took longer for some unexpected reason--perhaps a slow HTTP call, then it'd block the pipeline.

By moving them to the bottom, it allows the main image to proceed with `apt-get update && apt-get install ...` which takes a little bit of time and gives any slow concurrent builds plenty of time to finish.
@jeffwidman jeffwidman force-pushed the move-copying-pythons-to-end-of-dockerfile branch from 6565140 to f68f582 Compare August 31, 2023 16:25
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeffwidman jeffwidman enabled auto-merge (squash) August 31, 2023 16:34
@jeffwidman jeffwidman merged commit 51b268a into main Aug 31, 2023
96 checks passed
@jeffwidman jeffwidman deleted the move-copying-pythons-to-end-of-dockerfile branch August 31, 2023 16:41
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…ot#7941)

This is a multi-stage build, which means that building/tarring these files happens in concurrent builds.

Previously, if one of those builds took longer for some unexpected reason--perhaps a slow HTTP call, then it'd block the pipeline.

By moving them to the bottom, it allows the main image to proceed with `apt-get update && apt-get install ...` which takes a little bit of time and gives any slow concurrent builds plenty of time to finish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants