Stop installing apt packages for compiling Python #7943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
no-need-to-install-apt-packages-into-python-core-image
branch
from
c27c418
to
4ec70fd
Compare
Nishnha
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
LGTM I compared this to the suggested build environment list for pyenv https://github.com/pyenv/pyenv/wiki#suggested-build-environment
The only one not listed here was curl but I guess that's installed elsewhere
|
I'm going to try deploying this in prod and see what Sentry shows for user errors... but again, probably we should move forward with this, and then add back missing packages as needed in a follow-on PR to dependabot-core/python/Dockerfile Lines 128 to 143 in 51b268a |
Now that we've stopped compiling Python from source and instead download/copy a pre-compiled version, there's no need to install these apt packages. A few may be needed for users to build python deps written in native C, but those shouldn't be listed in this section, they should be added later in the the Dockerfile where we already list other packages needed for that: https://github.com/dependabot/dependabot-core/blob/51b268a81a983c6547af4d95768218a03bd8e751/python/Dockerfile#L128-L143 Also, it's unclear which of these would be needed, so let's start by removing these, and then as needed can add back the couple that we actually discover are needed.
jeffwidman
force-pushed
the
no-need-to-install-apt-packages-into-python-core-image
branch
from
4ec70fd
to
021fca9
Compare
jeffwidman
deleted the
no-need-to-install-apt-packages-into-python-core-image
branch
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Now that we've stopped compiling Python from source and instead download/copy a pre-compiled version, there's no need to install these apt packages. A few may be needed for users to build python deps written in native C, but those shouldn't be listed in this section, they should be added later in the the Dockerfile where we already list other packages needed for that: https://github.com/dependabot/dependabot-core/blob/51b268a81a983c6547af4d95768218a03bd8e751/python/Dockerfile#L128-L143 Also, it's unclear which of these would be needed, so let's start by removing these, and then as needed can add back the couple that we actually discover are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've stopped compiling Python from source and instead download/copy a pre-compiled version, there's no need to install these apt packages.
A few may be needed for users to build python deps written in native C, but those shouldn't be listed in this section, they should be added later in the the Dockerfile where we already list other packages needed for that:
dependabot-core/python/Dockerfile
Lines 128 to 143 in 51b268a
Also, it's unclear which of these would be needed, so let's start by removing these, and then as needed can add back the couple that we actually discover are needed.