go: fix ambiguous import when using a module without a dot #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in Go 1.20 (see golang/go#61873), when importing a module without a dot in it, we get: ``` 18:13 ❱ GOTOOLCHAIN="go1.20+auto" go get akvorado: ambiguous import: found package akvorado in multiple modules: akvorado (/home/bernat/code/free/akvorado) (/home/bernat/src/gocode/pkg/mod/golang.org/toolchain@v0.0.1-go1.20.linux-amd64/src/akvorado) ``` This issue was fixed in Go 1.20.8 which was just released. By using `go1.20.8` as a toolchain for anything <= 1.20, we still cover the use case introduced in dependabot#7884, but we also avoid this bug. `go1.20.8` is a valid toolchain. For Go 1.20, only `go1.20` is a valid version for `go` directive in `go.mod`.
jakecoffman
approved these changes
Sep 6, 2023
|
@vincentbernat This is deployed now. Since you can reproduce the problem can you rerun the job and verify that it's fixed? Thanks! |
|
It works fine now, thanks! https://github.com/akvorado/akvorado/network/updates/718843474 |
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…t#7979) Due to a bug in Go 1.20 (see golang/go#61873), when importing a module without a dot in it, we get: ``` 18:13 ❱ GOTOOLCHAIN="go1.20+auto" go get akvorado: ambiguous import: found package akvorado in multiple modules: akvorado (/home/bernat/code/free/akvorado) (/home/bernat/src/gocode/pkg/mod/golang.org/toolchain@v0.0.1-go1.20.linux-amd64/src/akvorado) ``` This issue was fixed in Go 1.20.8 which was just released. By using `go1.20.8` as a toolchain for anything <= 1.20, we still cover the use case introduced in dependabot#7884, but we also avoid this bug. `go1.20.8` is a valid toolchain. For Go 1.20, only `go1.20` is a valid version for `go` directive in `go.mod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in Go 1.20 (see golang/go#61873), when importing a module without a dot in it, we get:
This issue was fixed in Go 1.20.8 which was just released. By using
go1.20.8as a toolchain for anything <= 1.20, we still cover the use case introduced in #7884, but we also avoid this bug.go1.20.8is a valid toolchain. For Go 1.20, onlygo1.20is a valid version forgodirective ingo.mod.