Maven: fix classifier being part of the dependency name #7980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
changed the title
landongrindheim
approved these changes
Sep 6, 2023
|
This fixes the issue in the repro, merging. |
jakecoffman
deleted the
jakecoffman/fix-maven-classifier-is-not-dep-name
branch
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1924 the classifier was added to take account of the different URL pattern needed to pull the dependency, however it was added to the dependency name and this has caused some issues around
allowandignore.I've put up a repro here: https://github.com/dsp-testing/maven-no-make-pr
Since it is appending the classifier to the end of the dependency name, the allow is preventing the update.
To fix this I moved the classifier into the dependency metadata, which didn't exist when #1924 was created, but now is a perfect place for this data to live!