Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorbet dependencies #8007

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Add sorbet dependencies #8007

merged 3 commits into from
Sep 11, 2023

Conversation

JamieMagee
Copy link
Contributor

Part of #7782 and step 1 of the adopting Sorbet in an existing codebase guide.

This will be followed with step 2 initializing sorbet

@JamieMagee JamieMagee requested a review from a team as a code owner September 11, 2023 17:16
Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not sure what the difference between adding these gems here versus https://github.com/dependabot/dependabot-core/blob/main/common/dependabot-common.gemspec is.

@JamieMagee
Copy link
Contributor Author

Yeah, I was torn too. But given the VSCode integration gems are installed here, it seemed like the more appropriate place for the Sorbet gems as well.

Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the omnibus uses the common gemspec so I guess it doesn't really matter where we install them as long as these tools are accessible from a bin/docker-dev-shell container

@JamieMagee JamieMagee mentioned this pull request Sep 11, 2023
8 tasks
@mctofu
Copy link
Contributor

mctofu commented Sep 11, 2023

Hmm not sure what the difference between adding these gems here versus https://github.com/dependabot/dependabot-core/blob/main/common/dependabot-common.gemspec is.

If we will need it to be available when running/testing the individual ecosystem gems it should go in dependabot-common.

@JamieMagee
Copy link
Contributor Author

Yes, they'll be needed to power both IDE integrations, as well as in individual ecosystems. I'll move them to common.

@Nishnha
Copy link
Member

Nishnha commented Sep 11, 2023

Hmm maybe it's me but that didn't work. Did I run it right?

This was for when it was installed into omnibus. I'll check again once it's in common

$ git checkout jamiemagee/add-sorbet
> branch 'jamiemagee/add-sorbet' set up to track 'jamie/jamiemagee/add-sorbet'.
> Switched to a new branch 'jamiemagee/add-sorbet'

$ script/build bundler
> [+] Building 42.0s (43/43) FINISHED

[dependabot-core-dev] ~ $ cd bundler
[dependabot-core-dev] ~/bundler $ bundle install
> Resolving dependencies...

[dependabot-core-dev] ~/bundler $ bundle exec sorbet
> bundler: command not found: sorbet
> Install missing gem executables with `bundle install`

@JamieMagee
Copy link
Contributor Author

@Nishnha Sorbet is available using srb

$ bundle exec srb
No sorbet/ directory found. Maybe you want to run 'srb init'?

A type checker for Ruby

Usage:
  srb                                 Same as "srb t"
  srb (init | initialize)             Initializes the `sorbet` directory
  srb rbi [options]                   Manage the `sorbet` directory
  srb (t | tc | typecheck) [options]  Typechecks the code

Options:
  -h, --help     View help for this subcommand.
  --version      Show version.

For full help:
  https://sorbet.org

@Nishnha Nishnha merged commit 9e30050 into dependabot:main Sep 11, 2023
96 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/add-sorbet branch September 11, 2023 19:55
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants