Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed: false sigil #8015

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Add typed: false sigil #8015

merged 1 commit into from
Sep 12, 2023

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Sep 12, 2023 •
edited
Loading

Type sigils are what Sorbet calls the comments at the beginning of each file. It tells Sorbet what level of type checking to apply. They range from typed: ignore which completely ignores the file, to typed: strong, which requires explicit types for all methods and disallows T.untyped

All errors silenced All errors reported
typed: ignore typed: false typed: true typed: strict typed: strong

This change explicitly sets all files to typed: false

See Sorbet's documentation on file-level granularity: strictness levels for more information about the requirements at each strictness level.

NOTE: this PR was originally created as https://github.com/JamieMagee/dependabot-core/pull/1

@JamieMagee JamieMagee requested a review from a team as a code owner September 12, 2023 17:38
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages labels Sep 12, 2023
@jakecoffman jakecoffman enabled auto-merge (squash) September 12, 2023 17:48
@jakecoffman jakecoffman merged commit 704fa1f into dependabot:main Sep 12, 2023
79 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/sorbet-sigils branch September 12, 2023 18:00
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JamieMagee
Add typed: false sigil (dependabot#8015)
92e5e65
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre approved these changes

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieMagee @jurre @jakecoffman