Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker-dev-shell on ARM #8029

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix docker-dev-shell on ARM #8029

merged 1 commit into from
Sep 13, 2023

Conversation

jakecoffman
Copy link
Member

Fixes the freeze on bundle install when running bin/docker-dev-shell common --rebuild on ARM.

Not sure why install_if worked in common but doesn't work in omnibus. Plain ole if seems ok though!

@jakecoffman jakecoffman requested a review from a team as a code owner September 13, 2023 19:02
@JamieMagee
Copy link
Contributor

I don't have permissions to approve, but this works locally for me, and it works in CI too. Thanks!

@jakecoffman jakecoffman enabled auto-merge (squash) September 13, 2023 20:03
@jakecoffman jakecoffman merged commit 7cf0091 into main Sep 13, 2023
63 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/fix-docker-dev-shell-on-arm branch September 13, 2023 20:10
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@jakecoffman
fix docker-dev-shell on ARM (dependabot#8029)
10c7e92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mctofu mctofu mctofu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakecoffman @JamieMagee @mctofu