Add back the Docker::Version.correct? method #8030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#correct?
method mimics creating a newDocker::Version
without actually instantiating one. It checks that the semver part of theDocker::Version
is actually valid semver.The previous version of this method called
#new
andDocker::Version#new
would callGem::Version#new
which would call#correct?
, and it would get stuck in an infinite loop, so it was removed.This PR adds in a working version of the method and there are already existing test cases for it like
dependabot-core/docker/spec/dependabot/docker/version_spec.rb
Lines 30 to 45 in 7cf0091