Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 Use defaults instead of comments for documentation #8069

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

landongrindheim
Copy link
Member

@landongrindheim landongrindheim commented Sep 19, 2023

The documentation that was generated when this was installed has been causing warnings to be added to PR diffs. These values are defaults, which seem to be just as helpful as the comments which were added.

Source for defaults

This is meant to address 👇 warnings
image

The documentation that was generated when this was installed has been
causing warnings to be added to PR diffs. These values are defaults,
which seem to be just as helpful as the comments which were added.

Source for defaults: https://github.com/Shopify/tapioca/blob/fa61b834119d4a9dc0643862d4ad4804225b0ab9/README.md?plain=1#L879-L935
@landongrindheim landongrindheim requested a review from a team as a code owner September 19, 2023 18:15
@landongrindheim landongrindheim merged commit f442120 into main Sep 19, 2023
97 checks passed
@landongrindheim landongrindheim deleted the silence-yaml-lint-warnings branch September 19, 2023 18:29
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…warnings

💅 Use defaults instead of comments for documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants