Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up test lockfile with parser 3.2.2.4 release #8142

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

The new parser 3.2.2.4 release has caused a new test failure.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner October 4, 2023 12:45
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for now. Anyway we can make this less dependent on latest released version, for example by specifying a range in the Gemfile?

@deivid-rodriguez
Copy link
Contributor Author

I thought of that but I imagined that if I specify a range, it will also be updated and still cause the issue? Maybe change the Gemfile to use a dev dependency that does not have transitive dependencies?

@deivid-rodriguez
Copy link
Contributor Author

Thanks @jakecoffman!

Happy to make this test more robust but merging for now just to get CI back to green!

@deivid-rodriguez deivid-rodriguez merged commit 1da7f97 into main Oct 4, 2023
92 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/fix-ci branch October 4, 2023 13:54
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants