Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve detection of unsupported cargo toolchains #8181

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Improve detection of unsupported cargo toolchains #8181

merged 3 commits into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. Prefer raise to raise e 

    This is almost the same thing as before, but `raise` without an argument
lets the original error instance be raised. However, `raise e` raises a
new instance of the same error, resulting in slightly harder to parse
backtraces.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    9bcb67b View commit details
    Browse the repository at this point in the history

  2. If we're not sure it was a resolvability error, raise original error

    @deivid-rodriguez
    deivid-rodriguez committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e1c8dce View commit details
    Browse the repository at this point in the history

  3. More robust detection of unsupported toolchains 

    Currently we look for an error when trying to use a flag that's not
supported by old toolchains. However, I think cargo downloads the user
selected toolchain on the fly and that may fail before even getting the
error about the unsupported flag.

I think we may also detect that the old version is getting downloaded
and error in the same way.
    @deivid-rodriguez
    deivid-rodriguez committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    39bb742 View commit details
    Browse the repository at this point in the history