Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for v234 release bugs #8218

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

LakSenanayaka
Copy link

This PR fixes the issues in importing dependancies in git_submodules and common, our CI caught during the building of https://github.com/dependabot/dependabot-core/releases/tag/v0.234.0 release. These issues exist since https://github.com/dependabot/dependabot-core/releases/tag/v0.233.0 as well.

To recreate the issue,
docker run --pull never --env CI=true --env RAISE_ON_WARNINGS=true --env SUITE_NAME=git_submodules --rm ghcr.io/dependabot/dependabot-updater-gitsubmodule bash -c "cd /home/dependabot/git_submodules && ./script/ci-test"

This PR fixes issues like,

An error occurred while loading ./spec/dependabot/dependency_group_spec.rb.
Failure/Error: extend T::Sig

NameError:
uninitialized constant WildcardMatcher::T
extend T::Sig

Failures:

  1. Dependabot::GitSubmodules::UpdateChecker#can_update? given an outdated dependency
    Failure/Error: subject { checker.can_update?(requirements_to_unlock: :own) }

    RuntimeError:
    Unsupported package_manager submodules

@LakSenanayaka LakSenanayaka requested a review from a team as a code owner October 17, 2023 09:53
@github-actions github-actions bot added the L: git:submodules Git submodules label Oct 17, 2023
@annettejanewilson
Copy link

Just to add - we think we only saw this on our CI because it runs on a 32 core machine. TurboTests distributes the tests evenly across one process per core, so if the number of cores is high a lot of the tests run in isolation. These missing require issues are easily masked if some other test already caused the module to be loaded.

Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fixes!

lakini-senanayaka added 2 commits October 31, 2023 12:15
Co-authored-by: lakini-senanayaka <lakini.senanayaka@skyscanner.net>
@deivid-rodriguez deivid-rodriguez merged commit 0852723 into dependabot:main Oct 31, 2023
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: git:submodules Git submodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants