Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Bundler to 2.4.22 #8224

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Bump Bundler to 2.4.22 #8224

merged 6 commits into from
Nov 15, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

No description provided.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner October 17, 2023 16:12
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-2-4-21 branch 2 times, most recently from 722b7f2 to 9e4e6f7 Compare October 17, 2023 17:26
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Oct 17, 2023
@github-actions github-actions bot removed the L: ruby:bundler RubyGems via bundler label Oct 17, 2023
@deivid-rodriguez deivid-rodriguez marked this pull request as draft October 17, 2023 18:48
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Nov 8, 2023
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-2-4-21 branch 2 times, most recently from cf74805 to bad7e8a Compare November 8, 2023 21:34
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review November 8, 2023 21:35
@deivid-rodriguez
Copy link
Contributor Author

Finally found some time to wrap this up. Tricky upgrade, lots of things going on upstream!

@deivid-rodriguez deivid-rodriguez changed the title Bump Bundler to 2.4.21 Bump Bundler to 2.4.22 Nov 9, 2023
@deivid-rodriguez
Copy link
Contributor Author

Ended up going all the way to Bundler 2.4.22, which was just released.

landongrindheim
landongrindheim approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@landongrindheim landongrindheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the patch-by-patch approach you took in this upgrade ❤️ Looks great to me! 🚀

bundler/helpers/v2/lib/functions/version_resolver.rb Show resolved Hide resolved
@deivid-rodriguez
Fix typo in command to update lockfile
28ff78b
@deivid-rodriguez
Bump Bundler to 2.4.18
15fd8da
@deivid-rodriguez
Bump Bundler to 2.4.19
a75b336 
Wording of some errors was changed at
rubygems/rubygems#6871, so needed some tweaks.
@deivid-rodriguez
Bump Bundler to 2.4.20
56d3d1c 
* `Bundler::Fetcher#fetchers` was made private at
  rubygems/rubygems#6919.
* `Bundler::Index#search_all` returns an enumerator since
  rubygems/rubygems#6962.
@deivid-rodriguez
Bump Bundler to 2.4.21
9ee9e16
@deivid-rodriguez
Bump Bundler to 2.4.22
76d17e5
@deivid-rodriguez deivid-rodriguez merged commit 7e90f1c into main Nov 15, 2023
81 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/bundler-2-4-21 branch November 15, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landongrindheim landongrindheim landongrindheim approved these changes

@abdulapopoola abdulapopoola abdulapopoola approved these changes

Assignees
No one assigned
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @abdulapopoola @landongrindheim