Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock related Gemfile dependencies, but not everything that changed #8267

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Oct 24, 2023

#7621 fixed an issue where some dependencies were not getting requirement updates in the Gemfile in situations where users would usually expect them.

However, the fix was too aggressive and it caused also unrelated dependencies to the update being unlocked under some situations.

This PR implements a hopefully safer approach.

Fixes #8195.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner October 24, 2023 16:50
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Oct 24, 2023
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/fix-bundler-agressive-unlocks branch from b0b4e7b to 8d81e03 Compare October 24, 2023 19:55
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of grouped updates issues in the Bundler ecosystem this may fix as well.

Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/fix-bundler-agressive-unlocks branch from 353d628 to 00eb3f4 Compare October 25, 2023 11:07
@deivid-rodriguez
Copy link
Contributor Author

deivid-rodriguez commented Oct 25, 2023

During testing I found that this approach was creating several PRs for the same dependency sometimes (auto-grouped with others, and single dependency PRs). I changed the approach to one that's simpler and does not have this issue, namely, if any other top level dependencies changed versions during "force update", then add those too to the updated_dependencies array.

Co-authored-by: Nish Sinha <nishnha@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of sentry gems tries to update git sources
4 participants