-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlock related Gemfile dependencies, but not everything that changed #8267
Unlock related Gemfile dependencies, but not everything that changed #8267
Conversation
b0b4e7b
to
8d81e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of grouped updates issues in the Bundler ecosystem this may fix as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me!
353d628
to
00eb3f4
Compare
During testing I found that this approach was creating several PRs for the same dependency sometimes (auto-grouped with others, and single dependency PRs). I changed the approach to one that's simpler and does not have this issue, namely, if any other top level dependencies changed versions during "force update", then add those too to the updated_dependencies array. |
Co-authored-by: Nish Sinha <nishnha@github.com>
00eb3f4
to
4196a03
Compare
#7621 fixed an issue where some dependencies were not getting requirement updates in the Gemfile in situations where users would usually expect them.
However, the fix was too aggressive and it caused also unrelated dependencies to the update being unlocked under some situations.
This PR implements a hopefully safer approach.
Fixes #8195.