Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add # typed: false for bin files #8287

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

JamieMagee
Copy link
Contributor

These files are included in the spoom report, but didn't have a type sigil. These were found with grep --recursive --files-without-match --include "*.rb" "# typed: " .. Now the only .rb files without sigils are bundler spec fixtures.

@JamieMagee JamieMagee requested a review from a team as a code owner October 27, 2023 20:59
@JamieMagee JamieMagee merged commit 4a74fc5 into main Oct 28, 2023
63 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/type-false-bin branch October 28, 2023 00:01
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants