Replace pipenv lock with pipenv upgrade
#8312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/pipenv-upgrade
branch
3 times, most recently
from
3cf8eca
to
1f7247a
Compare
|
This smoke test failure is a bug/missing feature in pipenv: pypa/pipenv#6002. It's really not a big deal, so for now we can update the smoke test with the lockfile that we generate now. |
jakecoffman
approved these changes
Nov 1, 2023
deivid-rodriguez
force-pushed
the
deivid-rodriguez/pipenv-upgrade
branch
2 times, most recently
from
b1becdf
to
39b44ac
Compare
This means no spaces, and at least one operator. We'll need this for migrating to using `pipenv upgrade` under the hood, because we'll want to pass the specifier inline to pipenv like ``` pipenv upgrade <name><specifier> ``` and that breaks if it has spaces.
The `pipenv lock` command had several problems: * It upgrades all versions to the latest version, not just the dependency being upgraded. This required us to explicitly pin all top level dependencies to prevent them from being upgraded, and even so, we'd still give incorrect results sometimes, when unrelated transitive dependencies would also get unintendedly upgraded. * It not only resolved versions, but also installed packags, with the potential problems like missing OS dependencies associated with that.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/pipenv-upgrade
branch
from
1e6f35b
to
eec1c1a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pipenv lockcommand had several problems:It upgrades all versions to the latest version, not just the
dependency being upgraded. This required us to explicitly pin all top
level dependencies to prevent them from being upgraded, and even so,
we'd still give incorrect results sometimes, when unrelated transitive
dependencies would also get unintendedly upgraded.
It not only resolved versions, but also installed packags, with the
potential problems like missing OS dependencies associated with that.
Closes #6836.