Fix common CI

[deivid-rodriguez]

Apparently #8310 broke some common specs. No idea why CI did not catch that, but can be reproduced with

rspec ./spec/dependabot/file_fetchers/base_spec.rb:1646

from common.

This PR removes the signature from run_shell_command until we can address the real culprit, since that seems to let the specs pass.

[deivid-rodriguez]

@JamieMagee I think this may be a fun one for you 😃

[honeyankit]

This PR removes the signature from run_shell_command

Just checking, Is there any harm in removing the signature

[deivid-rodriguez]

I think @JamieMagee may answer that better but my understanding is that it just means less strict typing. It's definitely not a permanent solution, just a way to get our CI green for now and unblock other PRs. We would readd the signature and reenable strict typing as soon as we find the culprit.

[JamieMagee]

Can you share an example of the failure?

@deivid-rodriguez is right, it's just less strict type-checking

EDIT: this is what I get locally

1) Dependabot::FileFetchers::Base with submodules #clone_repo_contents does not clone submodules by default
     Failure/Error:
       expect(Dependabot::SharedHelpers)
         .to have_received(:run_shell_command).with(
           /\Agit clone .* --no-recurse-submodules/
         )
     
       Dependabot::SharedHelpers received :run_shell_command with unexpected arguments
         expected: (/\Agit clone .* --no-recurse-submodules/)
              got: ("git config --global credential.helper '!/home/jamie/src/work/dependabot-core/common/lib/dependabot/../../bin/git-credential-store-immutable --file /home/jamie/src/work/dependabot-core/common/git.store'", {:allow_unsafe_shell_command=>true, :fingerprint=>"git config --global credential.helper '<helper_command>'"})
       Diff:
       @@ -1,3 +1,5 @@
       -[/\Agit clone .* --no-recurse-submodules/]
       +["git config --global credential.helper '!/home/jamie/src/work/dependabot-core/common/lib/dependabot/../../bin/git-credential-store-immutable --file /home/jamie/src/work/dependabot-core/common/git.store'",
       + {:allow_unsafe_shell_command=>true,
       +  :fingerprint=>"git config --global credential.helper '<helper_command>'"}]
       
     # ./spec/dependabot/file_fetchers/base_spec.rb:1649:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:47:in `block (2 levels) in <top (required)>'

[JamieMagee]

What makes this change necessary?

[deivid-rodriguez]

Oh, nothing, this is just because I run sorbet locally, and since I had files at bundler/helpers/v1/.bundle and bundler/helpers/v2/.bundle (probably because of having run bundler specs), sorbet showed a bunch of failures in those installed gems.

[deivid-rodriguez]

Yes, see https://github.com/dependabot/dependabot-core/actions/runs/6774474932/job/18411610576?pr=8337.

[deivid-rodriguez]

I pushed a different change that allows specs to pass while keeping the strict typing. I guess this is just poor RSpec support.

[JamieMagee]

I pushed a different change that allows specs to pass while keeping the strict typing. I guess this is just poor RSpec support.

Poor RSpec support in Sorbet?

[deivid-rodriguez]

Yes, that's what I meant.

Just realized my change is not working, not sure why I thought it was 😢

[deivid-rodriguez]

Ok, I pushed yet another different approach. This one should be fine I believe.

[deivid-rodriguez]

I guess these could be related? In any case, I think it's best to not rely on these mocks and move on.