-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect poetry explicit source #8371
Respect poetry explicit source #8371
Conversation
a8f01bb
to
079745c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I added a few nitpick comments, nothing that blocks merging this as is, really, but feel free to address!
python/spec/dependabot/python/file_parser/pyproject_files_parser_spec.rb
Outdated
Show resolved
Hide resolved
python/spec/dependabot/python/update_checker/index_finder_spec.rb
Outdated
Show resolved
Hide resolved
python/spec/dependabot/python/update_checker/index_finder_spec.rb
Outdated
Show resolved
Hide resolved
python/spec/fixtures/pyproject_files/extra_source_explicit.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, could you squash all commits into one to simplify git history?
python/spec/dependabot/python/update_checker/index_finder_spec.rb
Outdated
Show resolved
Hide resolved
280bcab
to
4f68873
Compare
4f68873
to
4f19273
Compare
@deivid-rodriguez done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I will merge and deploy this later today! Thanks for the great work 💪
4f19273
to
d57649e
Compare
Thanks so much for the nice contribution! |
Context
explicit
source #7918 is being addressed to incorporate support for Poetry's explicit package source.Poetry 1.5.0 introduced the concept of an explicit package source, which can be found here: Explicit Package Sources.
Summary of Modifications
Testing
./bin/dry-run.rb
and check explicit package source won't be consider unless it is defined as the source of a packageUser facing changes
To-Do:
Fixes #7918.