Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn:update add a handled error for missing tags #8389

Merged
merged 1 commit into from
Nov 21, 2023
Merged

yarn:update add a handled error for missing tags #8389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ def handle_yarn_lock_updater_error(error, yarn_lock)
handle_timeout(error_message, yarn_lock) if error_message.match?(TIMEOUT_FETCHING_PACKAGE)

if error_message.start_with?("Couldn't find any versions") ||
error_message.include?(": Not found")
error_message.include?(": Not found") ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: is this issue only specific to yarn or does it impact pnpm and npm too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a specific yarn error message. There might be specific pnpm and npm error messages that are the "same" but they might already be matched by regex/strings in the respective code.

error_message.include?("Couldn't find match for")

raise_resolvability_error(error_message, yarn_lock) unless resolvable_before_update?(yarn_lock)

Expand Down