Ignore repo access issues while parsing actions dependencies #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Nov 23, 2023
deivid-rodriguez
force-pushed
the
deivid-rodriguez/ignore-action-access-issues-when-parsing-actions-dependencies
branch
from
d23ec0e
to
566e6e3
Compare
The functionality that needs accessing the dependency source is not critical, so skip it if the repo is not accessible. The end result of this should be that we still parse the dependency, and it will be properly ignore before checking for updates for it. If it's a non ignored dependency, we should be getting another `git_dependencies_not_reachable` error when checking for updates.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/ignore-action-access-issues-when-parsing-actions-dependencies
branch
from
566e6e3
to
3fb0d7f
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/ignore-action-access-issues-when-parsing-actions-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality that needs accessing the dependency source is not critical, so skip it if the repo is not accessible. The end result of this should be that we still parse the dependency, and it will be properly ignored before checking updates for it. If it's a non ignored dependency, we should be getting another
git_dependencies_not_reachableerror when checking for updates.