fix grouped update PRs are missing current -> updated version message #8478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
force-pushed
the
jakecoffman/fix-group-with-1-update-has-no-version-line
branch
from
6eb44c2
to
c9df1b3
Compare
jurre
approved these changes
Nov 28, 2023
jakecoffman
deleted the
jakecoffman/fix-group-with-1-update-has-no-version-line
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7662
Group PRs that only have 1 dependency are missing the version from -> to line.
There are examples in this very repo: #8459
The reason this happened is in the past, for PRs with one dependency the version update was included in the title. For grouped updates, the group info is included in the title, so the version info needs to be in the body. We just missed one place where we needed to check for a group.