Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach Dependabot how to present multi-directory PRs #8494

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Nov 30, 2023

Fix up the title and PR body for mutli-directory PRs so they split the dependency updates by directory.

So a mutli-dependency PR would look like

Screenshot 2023-11-30 at 4 19 27 PM

@Nishnha Nishnha marked this pull request as ready for review November 30, 2023 20:28
@Nishnha Nishnha requested a review from a team as a code owner November 30, 2023 20:28
@Nishnha
Copy link
Member Author

Nishnha commented Dec 1, 2023

This is what it looks like in practice

Screenshot 2023-12-01 at 11 06 42 AM

(/foo and /bar have the same dependencies in this example)

Not exactly what I was going for though - I wanted it to be:

"Bumps the go_modules group across 2 directories with 2 updates"

Updates github.com/consensys/gnark-crypto from 0.9.1 to 0.12.1
Updates golang.org/x/text from 0.0.0-20170915032832-14c0d48ead0c to 0.3.8

"Bumps the go_modules group across 2 directories with 2 updates"

Updates github.com/consensys/gnark-crypto from 0.9.1 to 0.12.1
Updates golang.org/x/text from 0.0.0-20170915032832-14c0d48ead0c to 0.3.8

But now I realize that if the PR body gets truncated, the summaries will be missing, so maybe it's okay that they're all at the top of the PR body?

I'm going to merge this PR and if we want to change it later we can. We still have to fix the branch name too.

@Nishnha Nishnha merged commit 05004b3 into main Dec 1, 2023
80 of 81 checks passed
@Nishnha Nishnha deleted the nishnha/fix-up-multi-dir-prs branch December 1, 2023 16:10
@carogalvin
Copy link
Contributor

The summary is duplicated at the top, will that happen every time?

@Nishnha
Copy link
Member Author

Nishnha commented Dec 4, 2023

The summary is duplicated at the top, will that happen every time?

No it will change depending on the dependencies updated for that directory. I'm going to make a minor change so that the directory is included in the summary, and then I'll share a better example with different dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants