Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Maven snapshots repositories from versions checking #8514

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Skip Maven snapshots repositories from versions checking #8514

merged 2 commits into from
Dec 4, 2023

Conversation

slawekjaranowski
Copy link
Contributor

  • snapshots repositories will be used for parent pom resolving
  • for available versions checking snapshots repositories will be excluded

fix #5947

@slawekjaranowski slawekjaranowski requested a review from a team as a code owner December 2, 2023 21:04
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Dec 2, 2023
@slawekjaranowski
Skip Maven snapshots repositories from versions checking
398cccc 
- snapshots repositories will be used for parent pom resolving
- for available versions checking snapshots repositories will be excluded

fix dependabot#5947
@slawekjaranowski
Copy link
Contributor Author

I'm not expert in Ruby ... 😄
I don't have an idea why build failed ....

Locally:

$ bin/docker-dev-shell maven 

=> running docker development shell
[dependabot-core-dev] ~ $ cd maven/
[dependabot-core-dev] ~/maven $ rspec spec
....
Finished in 4.25 seconds (files took 4.18 seconds to load)
426 examples, 0 failures

Please help by someone with more experience in project

jakecoffman
jakecoffman approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

The test failure looks like a pre-existing condition, I'll fix that up.

@jakecoffman
Copy link
Member

Fixed the test in #8527.

@jakecoffman jakecoffman merged commit 5cf31a7 into dependabot:main Dec 4, 2023
81 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-5947 branch December 5, 2023 07:47
@jtnord jtnord mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman approved these changes

Assignees
No one assigned
Labels
L: java:maven Maven packages via Maven
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependabot use snapshots repositories for checking released versions
2 participants
@slawekjaranowski @jakecoffman