Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix group update creation failure when a dependency is ignored #8535

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix group update creation failure when a dependency is ignored #8535

merged 2 commits into from
Dec 5, 2023

Conversation

jakecoffman
Copy link
Member

When checking to see if all versions are ignored, grouped security updates need to call lowest_security_fix_version, otherwise it will continue and throw AllVersionsIgnored which halts the update.

@jakecoffman jakecoffman marked this pull request as ready for review December 5, 2023 18:13
@jakecoffman jakecoffman requested a review from a team as a code owner December 5, 2023 18:13
Nishnha
Nishnha approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jakecoffman jakecoffman merged commit 720d2a8 into main Dec 5, 2023
81 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/fix-group-update-failure-when-one-dependency-is-ignored branch December 5, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nishnha Nishnha Nishnha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoffman @Nishnha