Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements to querying nuget apis for versions #8538

Merged
merged 4 commits into from
Dec 6, 2023
Merged

improvements to querying nuget apis for versions #8538

merged 4 commits into from
Dec 6, 2023

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Dec 6, 2023

This fixes 2 issues with querying NuGet apis:

  1. Allow querying from the trustedSigners section of NuGet.Config
  2. Allow querying v2 APIs to determine dependency eligibility

@brettfo brettfo requested a review from a team as a code owner December 6, 2023 00:14
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 6, 2023
@brettfo brettfo mentioned this pull request Dec 6, 2023
Merged
JoeRobich
JoeRobich approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions are just suggestions and are not blocking.

Changes look good to me.

nuget/lib/dependabot/nuget/file_parser/project_file_parser.rb Outdated Show resolved Hide resolved
nuget/lib/dependabot/nuget/update_checker/repository_finder.rb Show resolved Hide resolved
nuget/lib/dependabot/nuget/file_parser/project_file_parser.rb Outdated Show resolved Hide resolved
@brettfo brettfo force-pushed the dev/brettfo/nuget-additional-apis branch from 67038a5 to 848ca77 Compare December 6, 2023 17:45
@brettfo
Copy link
Contributor Author

brettfo commented Dec 6, 2023

Review suggestions applied and rebased onto latest main; once CI is done this should be ready to merge.

@brettfo brettfo force-pushed the dev/brettfo/nuget-additional-apis branch from 848ca77 to 39312d0 Compare December 6, 2023 18:41
@jakecoffman
Copy link
Member

@brettfo Are there any open nuget issues this will fix?

@brettfo
Copy link
Contributor Author

brettfo commented Dec 6, 2023

None that I can see. I started working on this one based on your comment to my previous PR.

@jakecoffman
Copy link
Member

Ah, that's right.

Confirmed this fixes dependabot update nuget udap-tools/udap-dotnet. All the KerErrors should be gone now, thanks!

@jakecoffman jakecoffman merged commit d33395f into main Dec 6, 2023
52 checks passed
@jakecoffman jakecoffman deleted the dev/brettfo/nuget-additional-apis branch December 6, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettfo @jakecoffman @JoeRobich