Prioritize detection of sha suffixed tags over date tags #8553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Dec 6, 2023
abdulapopoola
approved these changes
Dec 6, 2023
bdragon
approved these changes
Dec 6, 2023
mctofu
changed the title
If a tag uses both a date and a sha suffix, we'll want to ignore the sha suffix during comparisons. This prioritizes the sha suffix detection over the date detection so we'll properly ignore the sha suffix.
mctofu
force-pushed
the
mctofu/docker-sha-suffix-priority
branch
from
5fc3472
to
bfa2bbb
Compare
lucemia
added a commit
to lucemia/dependabot-core
that referenced
this pull request
Dec 12, 2023
jakecoffman
pushed a commit
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tag uses both a date and a sha suffix, we'll want to ignore the sha suffix during comparisons. This prioritizes the sha suffix detection over the date detection so we'll properly ignore the sha suffix.
The updates for tags like
20231101-230548-g159857a0bstarted failing once #8500 was merged as that caused them to be detected as:year_month_dayinstead of:sha_suffixed.