-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cachetool breaks PHP 7.4 Compatibility #2836
Comments
Well, according to Line 43 in 2d16b6d
|
@sprankhub Can you send a PR please? I'm happy to merge a pinned version. And a cherry on the cake would be if you add a configuration to set the version/url :-) |
@Schrank, thanks for the fast answer. Please review the linked PR. And sorry, not time for a configuration option at the moment 🙈 |
* Fix cachetool PHP 7 compatibility, fixes #2836 * Update cachetool.php Create configuration option to change cachetool version * Update doc Co-authored-by: Fabian Blechschmidt <github@fabian-blechschmidt.de> Co-authored-by: Fabian Blechschmidt <blechschmidt@fabian-blechschmidt.de>
🙏 |
Historically this seems to have been handled by checking the PHP version (https://github.com/deployphp/recipes/blob/master/recipe/cachetool.php#L13) but I suppose moving forward having to keep track of and updating this is not really viable. |
I think it makes sense for the current braking changes. And if it times in the future, we add new versions again 🤷 So feel free to send another PR :D @jamieburchell Thanks for coming up with the historical data <3 |
If you add the following to your
deploy.php
and try to deploy a PHP 7.4 project, you will get an error.The error looks like this:
The issue is that the cachetool is always used in the latest version:
deployer/contrib/cachetool.php
Line 57 in 2d16b6d
Unfortunately, the latest version dropped support for PHP 7, see https://github.com/gordalina/cachetool#compatibility.
I could not find any official information which PHP versions Deployer officially supports, but I think it should at least support all still maintained PHP versions (even if that PHP version only gets security fixes). So my suggested fix for now would be to fix the cachetool to version 7 and not use the latest version. Happy to send a PR.
What do you think?
The text was updated successfully, but these errors were encountered: