Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why in composer.json: platform: php: 7.3.0? #2927

Closed
benoitchantre opened this issue Jan 30, 2022 · 4 comments · Fixed by #3044
Closed

Why in composer.json: platform: php: 7.3.0? #2927

benoitchantre opened this issue Jan 30, 2022 · 4 comments · Fixed by #3044
Labels

Comments

@benoitchantre
Copy link
Contributor

These lines fake the PHP version available from the environment.

deployer/composer.json

Lines 64 to 66 in e3e1dac

"platform": {
"php": "7.3.0"
},

When the environment doesn't meet the requirements, there will be an error at runtine.
Without these lines, the error would be detected during composer install.

Are there any reasons to fake the environment?

@antonmedv
Copy link
Member

antonmedv commented Mar 3, 2022

¯\_(ツ)_/¯

@antonmedv antonmedv changed the title Composer config prevents checking PHP version from the environnment it's running Why in composer.json: platform: php: 7.3.0? Mar 3, 2022
@benoitchantre
Copy link
Contributor Author

The platform config has been introduced with a22faa6, then it has been updated when there was a bump of PHP requirement.

The commit message doesn’t help to understand why it has been introduced. I suspect there was a misunderstanding of that parameter.

I suggest to remove it and see what happens with automated tests.

@antonmedv
Copy link
Member

Let’s try this. Can you create pr?

@benoitchantre
Copy link
Contributor Author

Yes!

benoitchantre added a commit to benoitchantre/deployer that referenced this issue Mar 15, 2022
Don't fake the PHP version available from the environment.

Closes deployphp#2927.
antonmedv pushed a commit that referenced this issue Mar 15, 2022
Don't fake the PHP version available from the environment.

Closes #2927.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants