-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why in composer.json: platform: php: 7.3.0? #2927
Labels
Comments
¯\_(ツ)_/¯ |
antonmedv
changed the title
Composer config prevents checking PHP version from the environnment it's running
Why in composer.json: platform: php: 7.3.0?
Mar 3, 2022
The platform config has been introduced with a22faa6, then it has been updated when there was a bump of PHP requirement. The commit message doesn’t help to understand why it has been introduced. I suspect there was a misunderstanding of that parameter. I suggest to remove it and see what happens with automated tests. |
Let’s try this. Can you create pr? |
Yes! |
benoitchantre
added a commit
to benoitchantre/deployer
that referenced
this issue
Mar 15, 2022
Don't fake the PHP version available from the environment. Closes deployphp#2927.
antonmedv
pushed a commit
that referenced
this issue
Mar 15, 2022
Don't fake the PHP version available from the environment. Closes #2927.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These lines fake the PHP version available from the environment.
deployer/composer.json
Lines 64 to 66 in e3e1dac
When the environment doesn't meet the requirements, there will be an error at runtine.
Without these lines, the error would be detected during
composer install
.Are there any reasons to fake the environment?
The text was updated successfully, but these errors were encountered: