Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy fails if GIT user.name contains a single quote #3260

Closed
eleftrik opened this issue Aug 16, 2022 · 3 comments · Fixed by #3328
Closed

Deploy fails if GIT user.name contains a single quote #3260

eleftrik opened this issue Aug 16, 2022 · 3 comments · Fixed by #3328
Labels

Comments

@eleftrik
Copy link

  • Deployer version: 7.0.0
  • Deployment OS: MacOS 12.5

If GIT user.name config property contains a single quote (e.g. "Erik D'Ercole", as my full name), Deployer exits with an error:

[staging] run cd /__OMISSIS__/project-folder && (echo '{"created_at":"2022-08-16T16:46:26+0000","release_name":"13","user":"Erik D'Ercole","target":"staging"}' >> .dep/releases_log)
[staging] bash: line 1: unexpected EOF while looking for matching `"'
[staging] bash: line 2: syntax error: unexpected end of file
[staging]  error  in release.php on line 119:
[staging] exit code -1 (Unknown error)

Thank you

@antonmedv
Copy link
Member

Hmm, true)

@encodiaweb
Copy link

@antonmedv Thanks! Have you already planned a release including this commit?

@antonmedv
Copy link
Member

Yes, coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants