Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape metainfo to prevent bash syntax errors #3328

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

colinodell
Copy link
Contributor

Uses the escapeshellarg() function to wrap the JSON with single quotes and escape all other single quotes present in the JSON string. Closes #3260.

@antonmedv antonmedv merged commit d3156ff into deployphp:master Oct 2, 2022
midweste pushed a commit to midweste/deployer that referenced this pull request Oct 26, 2022
* origin/master: (40 commits)
  Laravel recipe: Skip database tasks if .env is missing (deployphp#3359)
  [automatic] Update docs with bin/docgen
  Add some notes on rsync --exclude option (deployphp#3350)
  Fix: deployphp#3319 - Receiving variables db_user and db_name (deployphp#3351)
  [automatic] Update docs with bin/docgen
  Remove default value for previous_release
  Escape metainfo to prevent bash syntax errors (deployphp#3328)
  [automatic] Update docs with bin/docgen
  Removed temporary workaround as it is for a version which is a year old (deployphp#3325)
  Feature/additional writable modes (deployphp#3316)
  Fix typo for SSH_KNOWN_HOSTS in CI/CD docs (deployphp#3310)
  Improve docs
  Update docs
  New recipes docs intro
  fix non-existing method (deployphp#3296)
  Update README.md
  Delete dependabot.yml
  [automatic] Update docs with bin/docgen
  Only delete symlink on broken release
  Remove validate config
  ...
schmengler pushed a commit to integer-net/deployer that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy fails if GIT user.name contains a single quote
2 participants