-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't add remote user to setfacl command, if it doesn't exist as an os user #2822
Merged
antonmedv
merged 3 commits into
deployphp:master
from
ElAberino:task/check-if-ssh-user-is-os-user
Jan 15, 2022
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also delete
exit 0
and useThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonmedv Does that mean I shall replace
test()
withrun()
again, astest()
doesn't have any additional options?If I just remove
|| exit 0
and use it withtest()
, it keeps working. I still gettrue
if the user exists andfalse
if it doesn't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, I see, sorry for misleading. Let me think a bit. Maybe test() should also have options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonmedv
I am not sure if that's necessary. I tried all variants to see how it works:
If the user does exist
run("id -u $remoteUser &>/dev/null 2>&1")
: Returns empty string -> the deployment continuesrun("id -u $remoteUser &>/dev/null 2>&1", ['no_throw' => true])
: Returns empty string -> the deployment continuestest("id -u $remoteUser &>/dev/null 2>&1")
: Returns true -> the deployment continuesIf the user doesn't exist
run("id -u $remoteUser &>/dev/null 2>&1")
: Throws exception -> the deployment is abortet with exit code 1.run("id -u $remoteUser &>/dev/null 2>&1", ['no_throw' => true])
: Returns empty string -> the deployment continuestest("id -u $remoteUser &>/dev/null 2>&1")
: Returns false -> the deployment continuesSo i'd say test() works as expected, but I am not aware of side effects you might see.