CakePHP recipe, use the configured PHP version #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the configured php version
antonmedv
reviewed
Jan 7, 2022
| @@ -25,15 +25,15 @@ | |||
| * Create plugins' symlinks | |||
| */ | |||
| task('deploy:init', function () { | |||
| run('{{release_or_current_path}}/bin/cake plugin assets symlink'); | |||
| run('{{bin/php}} {{release_or_current_path}}/bin/cake.php plugin assets symlink'); | |||
There was a problem hiding this comment.
yes, this file https://github.com/cakephp/app/blob/4.x/bin/cake.php called directly instead of the wrapper shell provided. It would allow you to use the right version of PHP configured in {{bin/php}} instead of relying on the shell to locate the default configured php version in the target env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the CakePHP recipe to use the configured PHP version instead of the target system default. Useful when multiple PHP versions installed in the deploy target.