Fix definition of {{bin/console}} parameter in Contao recipe #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameotoko
changed the title
ameotoko
changed the title
richardhj
added a commit
to richardhj/deployer-recipes
that referenced
this pull request
Aug 9, 2022
richardhj
added a commit
to nutshell-framework/deployer-recipes
that referenced
this pull request
Aug 9, 2022
midweste
pushed a commit
to midweste/deployer
that referenced
this pull request
Aug 23, 2022
* origin/master: (25 commits) Update README.md Update README.md Update README.md fix(typo): Missing backtick on deploy:cleanup command in upgrade.md (deployphp#3265) fix closing backtick for inline Markdown code (deployphp#3261) Typo in docs "oncePerNode" (deployphp#3248) fix typo in Rocket.Chat docs (deployphp#3234) Update release.yml Update docs Update docs Update docs Update docs Leave source files in release Revert "Rename back to deployer.phar" Pimcore recipe fixes (deployphp#3212) fix definition of {{bin/php}} parameter in Contao recipe (deployphp#3200) Add upgrade docs about default_stage (deployphp#3197) chore: add task name to replace exception message (deployphp#3184) Add migration info for `cleanup` task (deployphp#3161) Update UPGRADE.md (deployphp#3158) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the definition of
{{bin/console}}parameter to always use PHP version defined by user. It is consistent with the way it's done in Symfony recipe, which this recipe is based on.Fixes minor bug, where
contao_versiontask fails to run (can be verified by runningdeployer config, for example).