Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_selector and improve documentation on host labels and selection #3247

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

marvinhinz
Copy link
Contributor

@marvinhinz marvinhinz commented Aug 3, 2022

The default_selector was pretty quick to implement. I also added some documentation.

Would like to get some feedback on this!

congrats on the v7 release 🔥

@joelpittet
Copy link
Contributor

This looks pretty solid solution @marvinhinz 👏

@joelpittet
Copy link
Contributor

The documentation updates are a great touch too. Maybe could be shorter but they do describe the flexibility

@marvinhinz
Copy link
Contributor Author

Thanks! In the meantime i thought about another comfort feature. In addition to a default_selector, we could use selector maps or aliases. I'm a fan easy to remember commands, so for a big project setup with many servers a deployment to production can be a bit complicated as you might need to enter something like dep deploy stage=prod&role=web,role=special everytime.

add('selector_map', [
    "prod" => "stage=prod&role=web,role=special",
    "staging" => "stage=staging",
]);

could then result in:

dep deploy prod

@antonmedv whats you opinion on this?

@marvinhinz
Copy link
Contributor Author

@antonmedv seems like in the meantime you added documentation about the selectors itself, would you consider the default_selector functionality to be merged when i update this pr to the new documentation?

@joelpittet
Copy link
Contributor

@antonmedv poking this as I still think it's a good idea but interested in your opinion/take as maintainer.

@antonmedv antonmedv merged commit 0aaa80e into deployphp:master Jun 13, 2024
9 checks passed
@joelpittet
Copy link
Contributor

Whoa thanks @antonmedv for the quick turn around on the poke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants