Split asset compilation #3326

renttek · 2022-09-30T11:28:42Z

This PR adds the improvements from #3311
The new variables have comments explaining the supported configuration options/structure

recipe/magento2.php

peterjaap

Process Simon's typo fixes

Co-authored-by: Simon Sprankel <sprankhub@users.noreply.github.com>

sprankhub · 2022-10-17T19:53:09Z

@renttek, mind checking the pipeline issue?

renttek · 2022-10-18T09:58:57Z

@sprankhub I'll them pipeline issues later this week. (Latest at the weekend 🙂)

sprankhub · 2022-10-24T15:27:39Z

Really, @renttek? 😛

renttek · 2022-10-25T09:37:03Z

Sorry, it slipped my mind a bit. I fixed the issues and updated the PR 🙂

schmengler · 2022-10-31T17:58:39Z

recipe/magento2.php

+    if ($useDefaultLanguages) {
+        $themes = implode('-t ', $themes);
+
+        run("{{bin/php}} {{release_or_current_path}}/bin/magento setup:static-content:deploy --area=$staticContentArea --content-version={{content_version}} {{static_deploy_options}} $defaultLanguages $themes -j {{static_content_jobs}}");


Should we add --force here by default? Otherwise deploy mode has to be "production" and on a build server you usually don't have that configured

I think this makes sense

The implode should be also reviewed.
If I have this:

array ( 0 => 'Hyva/default', 1 => 'Magento/luma', )

The implode makes this:

Hyva/default-t Magento/luma

However it should be this:

-t Hyva/default -t Magento/luma

the implode is updated and the force option is added as well.

@akosglue great, could you also fix the merge conflicts?

seems to be resolved now

@peterjaap any chance to merge this?

schmengler · 2022-10-31T18:09:40Z

recipe/magento2.php

+
+// backend themes to deploy. Only used if split_static_deployment=true
+// This setting supports the same options/structure as {{magento_themes}}
+set('magento_themes_backend', ['Magento/backend']);


the default value should be ['Magento/backend' => null]

you are right. I'll fix this later

I have committed the change for this.

sprankhub · 2023-01-30T07:54:48Z

Why has this been closed, @antonmedv?

antonmedv · 2023-01-30T09:39:00Z

Please resolve conflicts.

akosglue · 2023-03-01T15:37:42Z

composer.json

@@ -48,6 +48,7 @@
        "react/http": "^1.5",
        "symfony/console": "^5",
        "symfony/polyfill-php80": "^1.22",
+        "symfony/polyfill-php81": "^1.26",


Do we need that requirement here in this PR?

I think it is required anyways, for example:

symfony/dependency-injection v5.4.20 requires symfony/polyfill-php81 (^1.22)
and
web-token/jwt-framework v2.2.11 requires symfony/dependency-injection (^4.2|^5.0)
and
magento/product-community-edition 2.4.5-p1 requires web-token/jwt-framework (^v2.2.7)

So when you have a magento installation you will have polyfill-php81 (since magento 2.4.4), or I am wrong somewhere?

akosglue · 2023-03-06T10:54:31Z

I have a couple of commits for this PR, if you give access @renttek I can push it?

Pushing to https://github.com/renttek/deployer
remote: Permission to renttek/deployer.git denied to akosglue.
fatal: unable to access 'https://github.com/renttek/deployer/': The requested URL returned error: 403

# Conflicts: # composer.lock # docs/recipe/magento2.md # recipe/magento2.php

akosglue · 2023-03-06T15:48:37Z

Well, I tried but something is amiss. (the hash of the lock file I think) @renttek
I first updated the master branch of https://github.com/renttek/deployer from the original repo (so the fork is up-to-date in comparison with deployer)
Then I merged the master onto the feature branch: https://github.com/renttek/deployer/tree/split-asset-compilation
I got 3 conflicts: the recipe was easily resolved, the lock file was wrongly solved and the the docs changes were ignored because afterwards I regenerated.
So I think I have to take a look at the hash of the lock file.
Edit: all tests passed on the feature branch after the merge.

# Conflicts: # docs/recipe/magento2.md

antonmedv · 2023-03-15T08:11:27Z

So, what’s the status? Merging?

akosglue · 2023-03-23T08:43:24Z

Yes, and hopefully it can fit into a new release, then we have a nice feature set in deployer for magento deployments.

renttek added 3 commits September 29, 2022 14:57

Split static content deployment by frontend/backend

37855fa

Use default locales as backend default locales

c4bbc38

Add comment to new magento asset compilation variables

05e1ad5

antonmedv requested review from peterjaap and Schrank October 1, 2022 16:18

sprankhub mentioned this pull request Oct 2, 2022

Magento 2: Add Support For --no-parent #3117

Closed

sprankhub reviewed Oct 2, 2022

View reviewed changes

recipe/magento2.php Outdated Show resolved Hide resolved

recipe/magento2.php Outdated Show resolved Hide resolved

peterjaap reviewed Oct 4, 2022

View reviewed changes

peterjaap and others added 2 commits October 4, 2022 16:55

Typo

9416f14

Co-authored-by: Simon Sprankel <sprankhub@users.noreply.github.com>

Typo

55e9c7c

Co-authored-by: Simon Sprankel <sprankhub@users.noreply.github.com>

renttek added 3 commits October 25, 2022 11:35

regenerate docs for m2

30d9615

Change exception to ConfigurationException

b7d6a9a

Add php 8.1 polyfills

7bec2a2

schmengler mentioned this pull request Oct 31, 2022

Split asset compilation integer-net/deployer#6

Merged

schmengler reviewed Oct 31, 2022

View reviewed changes

antonmedv closed this Jan 9, 2023

antonmedv reopened this Jan 30, 2023

akosglue reviewed Mar 1, 2023

View reviewed changes

akosglue added 2 commits March 6, 2023 11:45

set default value for backend

7732147

updated theme list

0128f75

akosglue added 2 commits March 6, 2023 15:39

added the force option

94fb713

Merge branch 'master' into split-asset-compilation

8084bca

# Conflicts: # composer.lock # docs/recipe/magento2.md # recipe/magento2.php

regenerated docs

665f90f

akosglue added 3 commits March 6, 2023 16:55

getting the lock file in sync with composer.json

0947aa0

Merge branch 'master' into split-asset-compilation

c5f6773

# Conflicts: # docs/recipe/magento2.md

regenerated docs

23b1af5

akosglue mentioned this pull request Mar 10, 2023

[IMPROVEMENT] allow to split Magento2 static file deployment in frontend and adminhtml area #3311

Closed

antonmedv merged commit 78dd230 into deployphp:master Mar 24, 2023

mfickers mentioned this pull request Mar 27, 2023

Magento 2: No themes are compiled if magento_themes is not set #3549

Closed

wilfriedwolf mentioned this pull request Mar 28, 2023

Magento2: No assets generated if default config is used. #3553

Closed

renttek deleted the split-asset-compilation branch September 21, 2023 12:06

peterjaap mentioned this pull request Mar 5, 2024

Magento 2: no assets generated when using custom magento_themes without split_static_deployment #3786

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split asset compilation #3326

Split asset compilation #3326

renttek commented Sep 30, 2022

peterjaap left a comment

sprankhub commented Oct 17, 2022

renttek commented Oct 18, 2022

sprankhub commented Oct 24, 2022

renttek commented Oct 25, 2022

schmengler Oct 31, 2022

renttek Nov 2, 2022

akosglue Mar 1, 2023

akosglue Mar 6, 2023

peterjaap Mar 6, 2023

akosglue Mar 8, 2023

akosglue Mar 15, 2023

schmengler Oct 31, 2022

renttek Nov 2, 2022

akosglue Mar 6, 2023

sprankhub commented Jan 30, 2023

antonmedv commented Jan 30, 2023

akosglue Mar 1, 2023

akosglue commented Mar 6, 2023

akosglue commented Mar 6, 2023 •

edited

Loading

antonmedv commented Mar 15, 2023

akosglue commented Mar 23, 2023

Split asset compilation #3326

Split asset compilation #3326

Conversation

renttek commented Sep 30, 2022

peterjaap left a comment

Choose a reason for hiding this comment

sprankhub commented Oct 17, 2022

renttek commented Oct 18, 2022

sprankhub commented Oct 24, 2022

renttek commented Oct 25, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sprankhub commented Jan 30, 2023

antonmedv commented Jan 30, 2023

Choose a reason for hiding this comment

akosglue commented Mar 6, 2023

akosglue commented Mar 6, 2023 • edited Loading

antonmedv commented Mar 15, 2023

akosglue commented Mar 23, 2023

akosglue commented Mar 6, 2023 •

edited

Loading