-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split asset compilation #3326
Split asset compilation #3326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Process Simon's typo fixes
@renttek, mind checking the pipeline issue? |
@sprankhub I'll them pipeline issues later this week. (Latest at the weekend 🙂) |
Really, @renttek? 😛 |
Sorry, it slipped my mind a bit. I fixed the issues and updated the PR 🙂 |
recipe/magento2.php
Outdated
if ($useDefaultLanguages) { | ||
$themes = implode('-t ', $themes); | ||
|
||
run("{{bin/php}} {{release_or_current_path}}/bin/magento setup:static-content:deploy --area=$staticContentArea --content-version={{content_version}} {{static_deploy_options}} $defaultLanguages $themes -j {{static_content_jobs}}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add --force
here by default? Otherwise deploy mode has to be "production" and on a build server you usually don't have that configured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implode should be also reviewed.
If I have this:
array (
0 => 'Hyva/default',
1 => 'Magento/luma',
)
The implode makes this:
Hyva/default-t Magento/luma
However it should be this:
-t Hyva/default -t Magento/luma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the implode is updated and the force option is added as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akosglue great, could you also fix the merge conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be resolved now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterjaap any chance to merge this?
recipe/magento2.php
Outdated
|
||
// backend themes to deploy. Only used if split_static_deployment=true | ||
// This setting supports the same options/structure as {{magento_themes}} | ||
set('magento_themes_backend', ['Magento/backend']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default value should be ['Magento/backend' => null]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right. I'll fix this later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed the change for this.
Why has this been closed, @antonmedv? |
Please resolve conflicts. |
@@ -48,6 +48,7 @@ | |||
"react/http": "^1.5", | |||
"symfony/console": "^5", | |||
"symfony/polyfill-php80": "^1.22", | |||
"symfony/polyfill-php81": "^1.26", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need that requirement here in this PR?
I think it is required anyways, for example:
symfony/dependency-injection v5.4.20 requires symfony/polyfill-php81 (^1.22)
and
web-token/jwt-framework v2.2.11 requires symfony/dependency-injection (^4.2|^5.0)
and
magento/product-community-edition 2.4.5-p1 requires web-token/jwt-framework (^v2.2.7)
So when you have a magento installation you will have polyfill-php81 (since magento 2.4.4), or I am wrong somewhere?
I have a couple of commits for this PR, if you give access @renttek I can push it?
|
# Conflicts: # composer.lock # docs/recipe/magento2.md # recipe/magento2.php
Well, I tried but something is amiss. (the hash of the lock file I think) @renttek |
# Conflicts: # docs/recipe/magento2.md
So, what’s the status? Merging? |
Yes, and hopefully it can fit into a new release, then we have a nice feature set in deployer for magento deployments. |
This PR adds the improvements from #3311
The new variables have comments explaining the supported configuration options/structure