Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple cachetool calls #3684

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Allow multiple cachetool calls #3684

merged 1 commit into from
Sep 12, 2023

Conversation

infabo
Copy link
Contributor

@infabo infabo commented Sep 11, 2023

  • Bug fix #…? No

  • New feature? Yes

  • BC breaks? I would say no. Possibly breaking for people that modified the recipe's tasks.

  • Tests added? No tests I am aware of. So none adjusted.

  • Docs added? Docs regenerated

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

Copy link
Contributor

@Schrank Schrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Interesting idea :-)

contrib/cachetool.php Outdated Show resolved Hide resolved
contrib/cachetool.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Schrank Schrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@antonmedv antonmedv merged commit 266554d into deployphp:master Sep 12, 2023
9 checks passed
@infabo infabo deleted the patch-1 branch September 13, 2023 06:55
@yard-mschwartz
Copy link

It turns out we had a copy of the default opcache clear command in deploy.php, which broke the our deployment pipeline since v7.3.2, that includes this change. Only God knows why. 🙃

The error being: Array to string conversion in Configuration.php on line 136

Anyway, this is now solved by removing this copy, that shouldn't have been there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants