Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website #3837

Merged
merged 3 commits into from
May 21, 2024
Merged

Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website #3837

merged 3 commits into from
May 21, 2024

Conversation

midhunmonachan
Copy link
Contributor

  • Bug fix: Fixes 2 bugs. Related issue: #3836

  • New feature: No features were added in this issue.

  • BC breaks: No backward compatibility breaks in this release.

  • Tests added: No new tests were added in this release.

  • Docs added: No new documentation was added in this release.

Moved the directory creation and ownership setting code before the file read operation to prevent the file read error.
@antonmedv antonmedv merged commit 5edee95 into deployphp:master May 21, 2024
9 checks passed
@midhunmonachan midhunmonachan deleted the hotfix/v7.4.0 branch May 24, 2024 03:34
midweste pushed a commit to midweste/deployer that referenced this pull request Jun 1, 2024
* origin/master: (40 commits)
  Improve the configuration options console output in provision:configure (deployphp#3840)
  Update Craft CMS deploy recipe (deployphp#3839)
  [automatic] Update docs with bin/docgen
  Update provision.php
  Feature/UI enhancements (deployphp#3835)
  Hotfix/v7.4.0: Fixes caddyfile and realpath errors in provision:website (deployphp#3837)
  [automatic] Update docs with bin/docgen
  docs(recipe/shopware): add code syntax highlighting (deployphp#3834)
  [automatic] Update docs with bin/docgen
  docs(recipe/magento2): fix typo in conccurent (deployphp#3830)
  [automatic] Update docs with bin/docgen
  magento2 theme processing fix for 3786 (deployphp#3818)
  use md5 of task name for section id in gitlab ci (deployphp#3817)
  [automatic] Update docs with bin/docgen
  Magento 2: Changed upgrading database (deployphp#3812)
  [automatic] Update docs with bin/docgen
  Shopware: Added `deploy:update_code` (deployphp#3816)
  [automatic] Update docs with bin/docgen
  Update nodejs to LTS version (deployphp#3815)
  Update LICENSE
  ...
@Wordlesschunk
Copy link

I'm still getting this error with symfony even on 7.4, had to downgrade to "deployer/deployer": "7.3.3",

@midhunmonachan
Copy link
Contributor Author

midhunmonachan commented Jun 12, 2024

I'm still getting this error with symfony even on 7.4, had to downgrade to "deployer/deployer": "7.3.3",

Hi, this is because this PR isn't in a release yet.

@antonmedv Any chance to make a minor release with the bugfix? Thanks

@antonmedv
Copy link
Member

Will release.

@calumshep
Copy link

Any news on this release? Also having to use 7.3.3 in the meantime.

@bendeckdavid
Copy link

There should be and var to allow to specify the caddyfile to use, if var is not set then use the default file, I was using a custom caddyfile and this update was a problem for me.

@antonmedv
Copy link
Member

This is a good idea. We can create a dir with all needed configuration go there. Like .dep/Caddyfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants