This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
Add reproduction for broken package ignore #4390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monorepo-builder configuration should ignore the package at `packages/monorepo-builder/ignore/composer.json` but the ExcludeFile iterator will only match against a sub-path. Running `composer merge` demonstrates that the invalid package contained in the test composer.json ends up in our root composer.json which is undesirable. Similarly using a relative path as argument to `packageDirectoriesExcludes` would not work either because the validation in that function requires the file to exist and it won't be able to properly resolve a relative file path.
|
Hi, thanks for the PR. I just got into this. This actually is not a test, but changing our local setup :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monorepo-builder configuration should ignore the package at
packages/monorepo-builder/ignore/composer.jsonbut the ExcludeFileiterator will only match against a sub-path.
Running
composer mergedemonstrates that the invalid package containedin the test composer.json ends up in our root composer.json which is
undesirable.
Similarly using a relative path as argument to
packageDirectoriesExcludeswould not work either because thevalidation in that function requires the file to exist and it won't be
able to properly resolve a relative file path.
Reproduces #4389