✨ feat: add banned word when create item #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunyoung1819
reviewed
Jul 3, 2023
backend/streetdrop-api/src/main/java/com/depromeet/domains/item/service/ItemService.java
Outdated
Show resolved
Hide resolved
yunyoung1819
reviewed
Jul 3, 2023
backend/streetdrop-api/src/main/java/com/depromeet/domains/item/service/ItemService.java
Outdated
Show resolved
Hide resolved
yunyoung1819
reviewed
Jul 3, 2023
backend/streetdrop-api/src/main/java/com/depromeet/common/repository/BannedWordRepository.java
Outdated
Show resolved
Hide resolved
|
IOS 팀과 논의한 결과 |
DongGeon0908
reviewed
Sep 6, 2023
backend/streetdrop-api/src/main/java/com/depromeet/common/repository/BannedWordRepository.java
Outdated
Show resolved
Hide resolved
seonghun-dev
force-pushed
the
feature/banned_word
branch
from
6fe94f3
to
b0e959c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #160 +/- ##
============================================
- Coverage 18.16% 16.85% -1.32%
Complexity 49 49
============================================
Files 44 46 +2
Lines 567 617 +50
Branches 15 18 +3
============================================
+ Hits 103 104 +1
- Misses 462 511 +49
Partials 2 2
|
|
@siyeonSon @yunyoung1819 |
siyeonSon
reviewed
Sep 23, 2023
backend/streetdrop-api/src/main/java/com/depromeet/common/annotation/NotBannedWord.java
Show resolved
Hide resolved
siyeonSon
reviewed
Sep 23, 2023
backend/streetdrop-api/src/main/java/com/depromeet/common/repository/BannedWordRepository.java
Show resolved
Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/common/repository/BannedWordRepository.java
Show resolved
Hide resolved
...eetdrop-api/src/main/java/com/depromeet/common/annotation/validator/BannedWordValidator.java
Outdated
Show resolved
Hide resolved
backend/streetdrop-domain/src/main/java/com/depromeet/common/entity/BannedWord.java
Outdated
Show resolved
Hide resolved
yunyoung1819
approved these changes
Oct 9, 2023
seonghun-dev
added a commit
that referenced
this pull request
Nov 8, 2023
* ✨ feat(api): add banned word validator * ✨ feat(api): add sql to flyway * ✨ fix(api): add fix query * ✨ feat(api) : add NotBannedWord annotation to ItemCreateRequestDto * ♻️ chore: change contentWord to contentWords * 🐛 fix: add access to noargsconstructor * 🐛 fix: fix test case and if null banned word is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve : #159