Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: add nickname change api #162

Merged
merged 2 commits into from
Jul 3, 2023
Merged

✨ feat: add nickname change api #162

merged 2 commits into from
Jul 3, 2023

Conversation

yunyoung1819
Copy link
Collaborator

Resolve: #158

@yunyoung1819 yunyoung1819 added ✨feature New feature or request 🥉d-2 With in 2 Day labels Jun 30, 2023
@yunyoung1819 yunyoung1819 self-assigned this Jun 30, 2023
@yunyoung1819 yunyoung1819 changed the title ✨ add nickname change api ✨ feat: Add nickname change api Jun 30, 2023
@yunyoung1819 yunyoung1819 changed the title ✨ feat: Add nickname change api ✨ feat: add nickname change api Jun 30, 2023
seonghun-dev
seonghun-dev requested changes Jul 1, 2023
View reviewed changes
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/controller/UserController.java Outdated Show resolved Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/service/UserService.java Outdated Show resolved Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/service/UserService.java Outdated Show resolved Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/security/config/WebSecurityConfig.java Show resolved Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/controller/UserController.java Outdated Show resolved Hide resolved
backend/streetdrop-api/src/main/java/com/depromeet/domains/user/service/UserService.java Outdated Show resolved Hide resolved
siyeonSon
siyeonSon approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@siyeonSon siyeonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@siyeonSon siyeonSon mentioned this pull request Jul 3, 2023
Merged
@yunyoung1819 yunyoung1819 merged commit 63da3c2 into main Jul 3, 2023
1 check passed
@yunyoung1819 yunyoung1819 deleted the feature/community-nickname branch July 3, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siyeonSon siyeonSon siyeonSon approved these changes

@seonghun-dev seonghun-dev Awaiting requested review from seonghun-dev

Assignees

@yunyoung1819 yunyoung1819

Labels
🥉d-2 With in 2 Day ✨feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Nickname Change API
3 participants
@yunyoung1819 @seonghun-dev @siyeonSon