✨ feat(notification): change memory storage -> mongoDB storage #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
siyeonSon
commented
Jul 14, 2023
•
siyeonSon
commented
- Resolve : Change memory storage -> mongoDB storage #194
siyeonSon
commented
Jul 15, 2023
Comment on lines
+73
to
+75
| public void save(TopicPushRequestDto tokenPushRequestDto) { | ||
| // TODO: 토픽 저장에 따른 스키마 변경 후 구체화 | ||
| } |
There was a problem hiding this comment.
현재 스키마로는 UserDevice 정보에 사용자가 구독하는 topic 정보를 저장하지 않아요.
토픽 별로 사용자에게 알림을 보내는 로직 구체화 후에 스키마를 변경해야 할 것 같아요!
|
알림 정보를 저장하는 로직은 좋은 방법을 생각해보고, 추가 이슈로 리팩토링하겠습니다! |
저장되는 json 정보💁♀️
|
seonghun-dev
approved these changes
Jul 15, 2023
backend/streetdrop-notification/src/main/java/com/depromeet/service/NotificationService.java
Show resolved
Hide resolved
backend/streetdrop-notification/src/main/java/com/depromeet/service/PushService.java
Show resolved
Hide resolved
backend/streetdrop-notification/src/main/java/com/depromeet/service/TokenService.java
Show resolved
Hide resolved
backend/streetdrop-notification/src/main/java/com/depromeet/service/NotificationService.java
Show resolved
Hide resolved
seonghun-dev
pushed a commit
that referenced
this pull request
Jul 18, 2023
* ✨ feat: create UserDeviceRepository * ✨ chore: find device token by userId * ✨ chore: find all device tokens * ✨ feat: save token * ✨ feat: update token * ✨ feat: delete token * ✨ chore: combine saveToken and insertToken * ✨ chore: add Transactional annotation * ✨ chore: change TokenRepository -> UserDeviceRepository in PushService * ✨ chore: change TokenRepository -> UserDeviceRepository in TopicService * ✨ chore: delete TokenRepository and MemoryTokenRepository * ✨ chore: rename createToken -> saveToken * ✨ feat: save notification * 🐛 fix: fix Query annotation of findAllDeviceTokens * ♻️ refactor: delete UserDevice * ♻️ refactor: delete deleteToken service logic * ♻️ refactor: change findDeviceTokenByUserId -> findByUserId * ♻️ refactor: find tokens using findDeviceTokenByUserId -> findByUserId * ♻️ refactor: add transactional annotation * ♻️ refactor: extract getting tokens logic into private method * ♻️ refactor: give space * ♻️ refactor: change token not found error message * 🔥 chore: remove Param annotation * ♻️ refactor: find tokens using findByUserId -> findDeviceTokenByUserId * ♻️ refactor: change token not found error message * ♻️ refactor: remove unused import statement * ♻️ refactor: notificationList save -> saveAll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.