Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(api): Add AWS S3 Config, S3 Service #221

Merged
merged 2 commits into from
Jul 15, 2023
Merged

✨ feat(api): Add AWS S3 Config, S3 Service #221

merged 2 commits into from
Jul 15, 2023

Conversation

yunyoung1819
Copy link
Collaborator

@yunyoung1819 yunyoung1819 added the ✨feature New feature or request label Jul 15, 2023
@yunyoung1819 yunyoung1819 self-assigned this Jul 15, 2023
Copy link
Collaborator

@seonghun-dev seonghun-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@siyeonSon siyeonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yunyoung1819 yunyoung1819 merged commit d15492b into dev Jul 15, 2023
1 check passed
@yunyoung1819 yunyoung1819 deleted the config/s3 branch July 15, 2023 12:55
seonghun-dev pushed a commit that referenced this pull request Jul 18, 2023
* ✨ feat(api): Add AWS S3 Config, S3 Service

* ✨ feat(api): remove hard coding strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants