Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add entity about city, state, village area #27

Merged
merged 7 commits into from
May 18, 2023

Conversation

seonghun-dev
Copy link
Collaborator

Resolve : #26

@seonghun-dev seonghun-dev requested review from siyeonSon and removed request for siyeonSon May 16, 2023 09:07
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #27 (552e51b) into main (f50a9ac) will increase coverage by 5.90%.
The diff coverage is 21.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main     #27      +/-   ##
==========================================
+ Coverage     3.50%   9.41%   +5.90%     
- Complexity       2       6       +4     
==========================================
  Files           11      16       +5     
  Lines           57      85      +28     
==========================================
+ Hits             2       8       +6     
- Misses          55      77      +22     
Impacted Files Coverage Δ
.../streetdrop/domains/area/city/entity/CityArea.java 0.00% <0.00%> (ø)
...treetdrop/domains/area/state/entity/StateArea.java 0.00% <0.00%> (ø)
...tdrop/domains/area/village/entity/VillageArea.java 0.00% <0.00%> (ø)
...depromeet/streetdrop/domains/item/entity/Item.java 0.00% <ø> (ø)
...drop/domains/itemLocation/entity/ItemLocation.java 0.00% <0.00%> (ø)
...area/village/controller/VillageItemController.java 100.00% <100.00%> (ø)
...mains/area/village/service/VillageItemService.java 100.00% <100.00%> (ø)

@seonghun-dev seonghun-dev marked this pull request as ready for review May 16, 2023 10:41
@seonghun-dev seonghun-dev self-assigned this May 16, 2023
@seonghun-dev seonghun-dev added the ✨feature New feature or request label May 16, 2023
@seonghun-dev seonghun-dev added this to the 1차 스프린트 milestone May 16, 2023
Copy link
Collaborator

@yunyoung1819 yunyoung1819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seonghun-dev seonghun-dev merged commit e6d55fd into main May 18, 2023
@seonghun-dev seonghun-dev deleted the feature/itemcount branch May 18, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Get drop item counts by region API
3 participants