♻️ refactor(notification): combine notification module and batch module #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
siyeonSon
commented
Mar 7, 2024
siyeonSon
commented
- Resolve: Combine notification module and batch module #444
…e to batch module
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #446 +/- ##
=========================================
Coverage 30.61% 30.61%
Complexity 125 125
=========================================
Files 77 77
Lines 980 980
Branches 30 30
=========================================
Hits 300 300
Misses 675 675
Partials 5 5 |
seonghun-dev
pushed a commit
that referenced
this pull request
May 8, 2024
…le (#446) * ♻️ refactor(notification): combine notification module and batch module * 🔥 refactor(notification): remove notification module * 🐛 test(notification): fix test fail * ♻️ refactor(notification): move notification domain from domain module to batch module * ♻️ refactor(notification): add space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.