Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix : can't find village bug fix #51

Merged
merged 2 commits into from
May 25, 2023
Merged

🐛 fix : can't find village bug fix #51

merged 2 commits into from
May 25, 2023

Conversation

seonghun-dev
Copy link
Collaborator

@seonghun-dev seonghun-dev commented May 24, 2023

resolve : #52

Description

Drop Item에서 village가 들어가지 않는 문제 Fix
Village를 찾지못하면 null로 들어감

@seonghun-dev seonghun-dev self-assigned this May 24, 2023
@seonghun-dev seonghun-dev added ✨feature New feature or request 🐛bug Something isn't working and removed ✨feature New feature or request labels May 24, 2023
@seonghun-dev seonghun-dev added this to the 1차 스프린트 milestone May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Merging #51 (1c6b661) into main (fc055bb) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
- Coverage     14.69%   14.34%   -0.36%     
  Complexity       26       26              
============================================
  Files            27       28       +1     
  Lines           245      251       +6     
============================================
  Hits             36       36              
- Misses          207      213       +6     
  Partials          2        2              
Impacted Files Coverage Δ
...mains/area/village/service/VillageAreaService.java 0.00% <0.00%> (ø)
...drop/domains/itemLocation/entity/ItemLocation.java 0.00% <0.00%> (ø)
...ains/itemLocation/service/ItemLocationService.java 0.00% <0.00%> (ø)

Copy link
Collaborator

@yunyoung1819 yunyoung1819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. Good

@seonghun-dev seonghun-dev merged commit 4dbdddc into main May 25, 2023
@seonghun-dev seonghun-dev deleted the fix/dropitems branch May 25, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Fix, When Drop Item can't find village
4 participants