Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ test: Add ItemController Test #63

Merged
merged 4 commits into from
Jun 2, 2023
Merged

✅ test: Add ItemController Test #63

merged 4 commits into from
Jun 2, 2023

Conversation

yunyoung1819
Copy link
Collaborator

Resolve: #45

@yunyoung1819 yunyoung1819 changed the title ✅ test: Add ItemController Test Code ✅ test: Add ItemController Test May 26, 2023
@yunyoung1819 yunyoung1819 self-assigned this May 26, 2023
@yunyoung1819 yunyoung1819 added the ✨feature New feature or request label May 26, 2023
Copy link
Member

@siyeonSon siyeonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 ItemSerivce Test도 PR 올려주시면 좋을 것 같아요! 고생하셨습니다😀

@siyeonSon siyeonSon added ✅test Add or update tests. and removed ✨feature New feature or request labels May 29, 2023
# Conflicts:
#	src/test/java/com/depromeet/streetdrop/apis/item/controller/ItemControllerTest.java
# Conflicts:
#	src/test/java/com/depromeet/streetdrop/unit/apis/item/controller/ItemControllerTest.java
@codecov-commenter
Copy link

Codecov Report

Merging #63 (029d683) into main (cc4b827) will increase coverage by 0.64%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
+ Coverage     51.45%   52.10%   +0.64%     
- Complexity       88       89       +1     
============================================
  Files            32       32              
  Lines           309      309              
  Branches          4        4              
============================================
+ Hits            159      161       +2     
+ Misses          148      146       -2     
  Partials          2        2              

see 1 file with indirect coverage changes

Copy link
Collaborator

@seonghun-dev seonghun-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다. 😄
감사합니다

@yunyoung1819 yunyoung1819 merged commit c2c296f into main Jun 2, 2023
@yunyoung1819 yunyoung1819 deleted the test/item-drop branch June 2, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅test Add or update tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Test Code for Item Drop API
4 participants