Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: 습관과 짝꿍 유무에 따라 믹스패널을 보내주는 위치 변경 #200

Merged
merged 1 commit into from
Jan 12, 2023
Merged

feature: 습관과 짝꿍 유무에 따라 믹스패널을 보내주는 위치 변경 #200

merged 1 commit into from
Jan 12, 2023

Conversation

juhwankim-dev
Copy link
Member

💁‍♂️ 변경 내용

AS-IS

  • collect 하는 부분에서 믹스패널 이벤트를 날려 리스트에 변화가 있을 때마다 중복된 이벤트가 발생했습니다.

TO-BE

  • viewModel에서 response를 받는 부분에서 바로 직접 이벤트를 날립니다.

📢 전달사항

fetchGoals -> fetchHabits로 네이밍 변경 (눈에 보이길래 그냥 같이 수정했습니다)

@juhwankim-dev juhwankim-dev added the bug Something isn't working label Jan 12, 2023
@juhwankim-dev juhwankim-dev self-assigned this Jan 12, 2023
@juhwankim-dev juhwankim-dev requested a review from a team as a code owner January 12, 2023 21:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@juhwankim-dev juhwankim-dev merged commit 2145b46 into develop Jan 12, 2023
@juhwankim-dev juhwankim-dev deleted the feature/DEP-390_mixpanel branch January 12, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@juhwankim-dev juhwankim-dev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juhwankim-dev